Shikiryu/Shikiryu_Backup
1
0
Fork 0
mirror of https://github.com/Chouchen/Shikiryu_Backup.git synced 2021-06-30 16:02:14 +02:00
Code Issues Packages Releases Wiki Activity

Avoid variables with short names and unused functions

Browse Source
This commit is contained in:
Shikiryu
2016-06-29 21:31:16 +02:00
parent 180765af3c
commit ffdf0b8476
3 changed files with 15 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/code/backup/BackupAbstract.php
View File

@@ -56,19 +56,19 @@ abstract class BackupAbstract
/**
* Check if all files got the minimum given size.
*
* @param int $fs
* @param int $file_size
*
* @return bool
*/
public function checkMinimumFilesize($fs)
public function checkMinimumFilesize($file_size)
{
foreach ($this->_filesToBackup as $file => $name) {
if (filesize($file) < $fs) {
if (filesize($file) < $file_size) {
return false;
}
}
foreach ($this->_streamsToBackup as $name => $file) {
if (mb_strlen($file, 'utf-8') < $fs) {
if (mb_strlen($file, 'utf-8') < $file_size) {
return false;
}
}

10
app/code/backup/Mysql.php
View File

@@ -15,7 +15,7 @@ class Mysql extends BackupAbstract
*/
protected $tables;
protected $host;
protected $db;
protected $database;
protected $login;
protected $pwd;
@@ -35,7 +35,7 @@ class Mysql extends BackupAbstract
if(!empty($tables)) {
$this->tables = $tables;
}
$this->_streamsToBackup[sprintf('db-%s.sql', $this->db)] = $this->getFromTables();
$this->_streamsToBackup[sprintf('db-%s.sql', $this->database)] = $this->getFromTables();
return $this;
}
@@ -49,7 +49,7 @@ class Mysql extends BackupAbstract
foreach($this->pdo->query('SHOW TABLES') as $table) {
$this->tables[] = $table;
}
$this->_streamsToBackup[sprintf('db-%s.sql', $this->db)] = $this->getFromTables();
$this->_streamsToBackup[sprintf('db-%s.sql', $this->database)] = $this->getFromTables();
return $this;
}
@@ -71,7 +71,7 @@ class Mysql extends BackupAbstract
$result2->execute();
$row2 = $result2->fetch();
$return.= "\n\n" . $row2[1] . ";\n\n";
foreach($result as $i=>$row){
foreach($result as $row){
$return.= 'INSERT INTO ' . $table . ' VALUES(';
for ($j = 0; $j < $num_fields; $j++) {
$row[$j] = addslashes($row[$j]);
@@ -102,7 +102,7 @@ class Mysql extends BackupAbstract
protected function preBuild()
{
$this->pdo = new \PDO('mysql:host='.$this->host.';dbname='.$this->db, $this->login, $this->pwd);
$this->pdo = new \PDO('mysql:host='.$this->host.';dbname='.$this->database, $this->login, $this->pwd);
}
protected function postBuild()